Fix various bugs and allow api keyword#17
Open
ahsand97 wants to merge 1 commit intowhoami730:cythonV2from
Open
Fix various bugs and allow api keyword#17ahsand97 wants to merge 1 commit intowhoami730:cythonV2from
ahsand97 wants to merge 1 commit intowhoami730:cythonV2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cyright module — PR description
Summary
Adds Cython
apikeyword support in the parser and type system, and wires the Cython extension settings (cython.typeCheckingMode,cython.includePaths) into the language server.Commit
bccdab3cf— Fix various bugs and allow api keywordChanges
1. Cython
apikeywordtokenizerTypes.ts— NewKeywordType.Api, added tovarModifiersandsoftKeywordssoapiis accepted wherepublicis (e.g.cdef public api void foo()).tokenizer.ts— Map'api'→KeywordType.Api.parseNodes.ts— AddCTypeNode.isApi(node)(same pattern asisPublic).types.ts— AddisApi?: booleantoCythonDetails; set it incloneForCTypefromCTypeNode.isApi(node).typePrinter.ts— When printing types, add'api'to the modifier list whendetails.isApi.completionProvider.ts— Add'api'to the Cython keyword list for completions.2. Cython configuration
configOptions.ts— SupporttypeCheckingMode === 'cython'and use a Cython-specific diagnostic rule set (e.g.getCythonDiagnosticRuleSet()).server.ts— Readcython.typeCheckingModeandcython.includePathsfrom thecythonconfig section; defaulttypeCheckingModeto'cython'when running as the Cython extension.References