Skip to content

Conversation

@Poundex
Copy link
Contributor

@Poundex Poundex commented Apr 4, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 63.32% when pulling cfc124d on Poundex:topic/scene-controller into 5479490 on whizzosoftware:master.

@whizzosoftware
Copy link
Owner

Thank you for submitting these changes. A couple of comments/questions:

  1. According to the Z-Wave Device Class Specification (if I'm reading things correctly), a Portable Scene Controller devices has the following mandatory command classes in addition to the ones you've already included: "Association", "Scene Controller Configuration", "Manufacturer Specific" and "Scene Activation". Ideally, those should be added to the constructor (except for perhaps Association because that is not yet supported anywhere). Otherwise, some TODO comments in the code would be helpful to indicate that the command class is not yet fully implemented.

  2. Are the "Central Scene" and "Battery" command classes implemented by all Portable Scene Controllers? If not, they shouldn't be added in the constructor of Portable Scene Controller or it could cause problems with portable scene controller devices that don't implement those command classes. They should only be included if the device interview indicates they are implemented by the device.

  3. According to the Z-Wave Application Command Class Specification, the "Central Scene" command class has 3 different versions. Which one(s) specifically are you trying to support with this new code? The implementation needs to be explicit about the maximum supported version number and implement all relevant version behavior or it can cause problems with certain portable scene controller devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants