Fix regex denial-of-service #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us reproduce the issue with the long duration
Check length of URL and limit to 8000 bytes Also added a unit test to check
Move runTimingTest() into TestRegex, and eliminate unnecessary variables
Author
|
This attempts to address GHSA-3f2q-6294-fmq5 and #24. It is an alternative to #25, but with a more generous URL length limit of 8000 instead of 1000. It still completes in 500 µs on my system, for a URL of 8000 characters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #24. Need to bump version from
v1.0.0tov1.0.1Otherwise I am going to have to start using my forked version since this shows up as a Dependabot warning now.
See https://github.com/mojotx/git-goclone/security/dependabot/10