feat: add "Did you mean?" suggestions for typos in location names #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create wkls/queries.py with all SQL query templates - Consolidate duplicate city suggestion queries using region_filter placeholder - Add _build_error_hint() helper to DRY error message construction - Update _get_suggestions() to use new consolidated queries - Standardize error messages to use 'No results found' consistently
- Fix Wkl.__getitem__ to return ChainableDataFrame instead of Wkl - Fix ChainableDataFrame.__getitem__ to continue chaining when _chain exists - Add test for bracket access suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wkls.us.ca.sanfransuggests "sanfrancisco")wkls/queries.pymodule for better maintainabilityFeatures
sanfran→sanfrancisco)wkls.us.cali→ca)wkls.u→us, ua, ug)wkls.us.ca['%sanfran%'])Changes
_get_suggestions()method toWklclass for fuzzy matching_build_error_hint()helper to DRY error message constructionwkls/queries.pywith all SQL query templates