Skip to content

Replace deprecated FILTER_SANITIZE_STRING #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Theta-Dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated FILTER_SANITIZE_STRING #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions www/account_manager/new_user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

foreach ($attribute_map as $attribute => $attr_r) {
if (isset($_POST[$attribute])) {
$$attribute = filter_var($_POST[$attribute], FILTER_SANITIZE_STRING);
$$attribute = sanitize_input_string($_POST[$attribute]);
}
elseif (isset($attr_r['default'])) {
$$attribute = $attr_r['default'];
Expand All @@ -56,10 +56,10 @@

if (isset($_GET['account_request'])) {

$givenname=filter_var($_GET['first_name'], FILTER_SANITIZE_STRING);
$givenname=sanitize_input_string($_GET['first_name']);
$new_account_r['givenname'] = $givenname;

$sn=filter_var($_GET['last_name'], FILTER_SANITIZE_STRING);
$sn=sanitize_input_string($_GET['last_name']);
$new_account_r['sn'] = $sn;

$uid = generate_username($givenname,$sn);
Expand All @@ -74,7 +74,7 @@

$new_account_r['cn'] = $cn;

$mail=filter_var($_GET['email'], FILTER_SANITIZE_EMAIL);
$mail=sanitize_input_string($_GET['email']);
if ($mail == "") {
if (isset($EMAIL_DOMAIN)) {
$mail = $uid . "@" . $EMAIL_DOMAIN;
Expand Down
2 changes: 1 addition & 1 deletion www/account_manager/show_user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
$$attribute = $user[0][$attribute][0];

if (isset($_POST['update_account']) and isset($_POST[$attribute]) and $_POST[$attribute] != $$attribute) {
$$attribute = filter_var($_POST[$attribute], FILTER_SANITIZE_STRING);
$$attribute = sanitize_input_string($_POST[$attribute]);
$to_update[$attribute] = $$attribute;
}
elseif (isset($attr_r['default'])) {
Expand Down
6 changes: 3 additions & 3 deletions www/includes/ldap_functions.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,19 +700,19 @@ function ldap_complete_account_attribute_array() {

$this_r = array();
$kv = explode(":", $this_attr);
$attr_name = strtolower(filter_var($kv[0], FILTER_SANITIZE_STRING));
$attr_name = strtolower(sanitize_input_string($kv[0]));

if (preg_match('/^[a-zA-Z0-9\-]+$/', $attr_name) == 1) {

if (isset($kv[1]) and $kv[1] != "") {
$this_r['label'] = filter_var($kv[1], FILTER_SANITIZE_STRING);
$this_r['label'] = sanitize_input_string($kv[1]);
}
else {
$this_r['label'] = $attr_name;
}

if (isset($kv[2]) and $kv[2] != "") {
$this_r['default'] = filter_var($kv[2], FILTER_SANITIZE_STRING);
$this_r['default'] = sanitize_input_string($kv[2]);
}

$additional_attributes_r[$attr_name] = $this_r;
Expand Down
6 changes: 6 additions & 0 deletions www/includes/web_functions.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,4 +545,10 @@ function update_email() {

}


function sanitize_input_string(string $string) {
$str = preg_replace('/\x00|<[^>]*>?/', '', $string);
return str_replace(["'", '"'], ['&#39;', '&#34;'], $str);
}

?>
8 changes: 4 additions & 4 deletions www/request_account/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,22 @@
array_push($error_messages, "You didn't enter your first name.");
}
else {
$firstname=filter_var($_POST['firstname'], FILTER_SANITIZE_STRING);
$firstname=sanitize_input_string($_POST['firstname']);
}

if (! isset($_POST['lastname']) or $_POST['lastname'] == "") {
array_push($error_messages, "You didn't enter your first name.");
}
else {
$lastname=filter_var($_POST['lastname'], FILTER_SANITIZE_STRING);
$lastname=sanitize_input_string($_POST['lastname']);
}

if (isset($_POST['email']) and $_POST['email'] != "") {
$email=filter_var($_POST['email'], FILTER_SANITIZE_EMAIL);
$email=sanitize_input_string($_POST['email']);
}

if (isset($_POST['notes']) and $_POST['notes'] != "") {
$notes=filter_var($_POST['notes'], FILTER_SANITIZE_STRING);
$notes=sanitize_input_string($_POST['notes']);
}


Expand Down