Fix DoubleTop indicator and improve docstrings#9
Merged
Conversation
The original implementation had mathematically impossible conditions: - cond_1: Today's close equals 60-day highest price - cond_3: Some historical price (30-55 days ago) is GREATER than 60-day highest These conditions could never both be true simultaneously. If today is the 60-day high, no other day in that window can be higher. ## Solution Replace contradictory logic with correct double-top pattern detection: 1. **First top**: Maximum price from 30-55 days ago (historical peak) 2. **Pullback**: Minimum price from 1-30 days ago (trough formation) 3. **Breakout**: Current price breaks above first top ## New Conditions - cond_1: Close at/near 60-day high (2% tolerance) - cond_2: Meaningful pullback occurred (5% below first top) - cond_3: First peak comparable to current price (within 10%) - cond_4: Current price breaks above first top - cond_5: Price above short-term SMA (uptrend) - cond_6: Price above long-term SMA (strong trend) - cond_7: Volume increasing (breakout confirmation) ## Benefits - Signals can now be generated when valid patterns are detected - Added comprehensive docstring explaining the pattern - Better error handling with try/except blocks - Uses percentage thresholds to handle floating-point precision Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the DoubleTop indicator logical contradiction and improves documentation:
Changes
Type of Change
Testing
The changes have been validated and are ready for merge.