Open
Conversation
Removed `echo "DDE_BROWSER ${DDE_BROWSER}"` that was a debug statement
accidentally left in the production code path.
Signed-off-by: Ueli Banholzer <ueli@whatwedo.ch>
`spotify/docker-gc` is an unmaintained, retired image. Replaced with `docker system prune -f --volumes` which is the modern built-in equivalent. The `walkerlee/nsenter fstrim` call is Linux-only and would fail silently or error on macOS — wrapped it in a `uname` check with an explicit skip notice on non-Linux systems. Signed-off-by: Ueli Banholzer <ueli@whatwedo.ch>
All five commands (shell, exec, fix-permissions, shell/root, exec/root) used the deprecated mikefarah/yq:3 image with v3 `yq r` syntax to detect the first service name. Replaced with the `_yq_stdin` helper (already used in project/up.sh) and v4 syntax. Also pinned the version tag in yq.sh from the implicit latest to `mikefarah/yq:4` for reproducibility. Signed-off-by: Ueli Banholzer <ueli@whatwedo.ch>
project/exec/root.sh defined project:exec() instead of project:exec:root()
project/open.sh called "open" on macOS which resolved to dde's own `open()` alias instead of /usr/bin/open
system:dde:install only called install:alias, skipping autocomplete setup entirely — contradicting README and user expectations. Now calls both install:alias and install:autocomplete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit history