fix(Filter): filters shouldn't add more body tags#60
Merged
rugbymauri merged 1 commit into1.0-devfrom Feb 12, 2026
Merged
Conversation
Ruesa18
force-pushed
the
fix/filter-controller-should-not-add-body-tags
branch
from
7704dde to
ce05cf0
Compare
renestalder
approved these changes
Feb 12, 2026
| const template = choosenOption.getAttribute('data-value-template') | ||
| const doc = parser.parseFromString(template.replace(/{name}/g, valueField.getAttribute('name')), 'text/html'); | ||
| valueField.parentNode.replaceChild(doc.body, valueField); | ||
| if(doc.body.childNodes[0] === undefined) { |
There was a problem hiding this comment.
Nit: Null/undefined check.
if(!doc.body.childNodes?.[0])
Contributor
Author
There was a problem hiding this comment.
@renestalder I adapted your example. I think the body can also be null. Because of that I also just now added another question mark there - just to be sure 🙂
There is an issue with changing from one filter to another with the "filter target" dropdown. If you change a filter, the stimulus controller will add a body tag with the filter element inside it. If you repeat doing that, you will have N amount of body tags in your DOM.
Ruesa18
force-pushed
the
fix/filter-controller-should-not-add-body-tags
branch
from
ce05cf0 to
6bed022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with changing from one filter to another with the "filter target" dropdown. If you change a filter, the stimulus controller will add a body tag with the filter element inside it. If you repeat doing that, you will have N amount of body tags in your DOM.