Skip to content

Action voter#98

Open
rugbymauri wants to merge 1 commit into1.0-devfrom
feature/1.0-actionVoter
Open

Action voter#98
rugbymauri wants to merge 1 commit into1.0-devfrom
feature/1.0-actionVoter

Conversation

@rugbymauri
Copy link
Contributor

No description provided.

Copy link
Member

@tuxes3 tuxes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rugbymauri

return array_filter(
$this->batchActions,
function (Action $action) {
return $this->container->get(AuthorizationCheckerInterface::class)->isGranted(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if voter_attribute is null we should allow it as well.

use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
use whatwedo\CoreBundle\Action\Action;

class DefaultActionVoter implements VoterInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need that Voter?

@tuxes3
Copy link
Member

tuxes3 commented Dec 14, 2022

@rugbymauri is this still active? if no response in a week i will close without merge

@tuxes3 tuxes3 force-pushed the 1.0-dev branch 2 times, most recently from 717962d to fd362da Compare April 26, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants