fix: moved symfony/stimulus-bundle and symfony/webpack-encore-bundle …#18
Merged
robinlehrmann merged 4 commits intodevelopfrom Mar 18, 2025
Conversation
added 3 commits
March 18, 2025 12:15
…to suggest Signed-off-by: Robin Lehrmann <robin@whatwedo.ch>
Signed-off-by: Robin Lehrmann <robin@whatwedo.ch>
Signed-off-by: Robin Lehrmann <robin@whatwedo.ch>
tuxes3
force-pushed
the
17-symfonystimulus-bundle-and-symfonywebpack-encore-bundle-should-be-optional
branch
from
0410a18 to
b1d9964
Compare
Signed-off-by: Nicolo Singer <nicolo@whatwedo.ch>
tuxes3
approved these changes
Mar 18, 2025
Member
tuxes3
left a comment
tuxes3
left a comment
There was a problem hiding this comment.
Thanks @robinlehrmann
please merge to develop and start a release for version 1.0.2
robinlehrmann
deleted the
17-symfonystimulus-bundle-and-symfonywebpack-encore-bundle-should-be-optional
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages
symfony/stimulus-bundleandsymfony/webpack-encore-bundleare not required and should be moved to suggest, because they are not necessary and only for the frontend of this bundle.