fix i386 syscall argument constraints #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at some point in the past it seems like the argument constraint went from "r" (rgeneral register) to "g" (anything but non-general registers) since all syscall callers are changing the stack pointer by pushing ebx on the stack without the compiler's knowledge, this causes bugs when the compiler chooses to save the argument on the stack, as it cannot reference it correctly later. switch back to "r" constraint to resolve this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at some point in the past it seems like the argument constraint went from "r" (rgeneral register) to "g" (anything but non-general registers) since all syscall callers are changing the stack pointer by pushing ebx on the stack without the compiler's knowledge, this causes bugs when the compiler chooses to save the argument on the stack, as it cannot reference it correctly later.
switch back to "r" constraint to resolve this issue.