Replace Safari auth with Slack desktop app cookie storage#11
Merged
Conversation
Remove Safari binary cookie parser (requires Full Disk Access) and switch to reading the Slack desktop app's Chromium cookie database. Cookie decryption uses PBKDF2 + AES-CBC with the Keychain password. - Remove internal/auth/safari.go and Safari-based auth provider - Add internal/auth/desktop.go with desktop cookie reader - Add internal/auth/cookie_password_darwin.go for Keychain access - Remove internal/users/ package (user resolution feature) - Update main.go to use new desktop auth provider - Set CGO_ENABLED=1 in .goreleaser.yml (needed for go-keychain) - macOS-only builds (darwin/amd64 + darwin/arm64) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wham
force-pushed
the
copilot/investigate-gh-slack-auth
branch
from
9d6ad94 to
1dca16a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Safari binary cookie parser (requires Full Disk Access) and switch to reading the Slack desktop app's Chromium cookie database. The new approach is consistent with
gh slackand lets the user approve a keychain prompt which is more transparent than giving full disk access to the terminal app.