Fix build on Clang #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Clang/libc++ including `<iostream>` is not enough to get the implementation of `ostringstream`. We need to include `<sstream>` as well. Also, the inclusion of libstdc++fs should no longer be necessary, and doesn't work on Clang either.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Clang/libc++ including
<iostream>is not enough to get the implementation ofostringstream. We need to include<sstream>as well.Also, the inclusion of libstdc++fs should no longer be necessary, and doesn't work on Clang either. (This is already handled by the other two PRs to some degree, but I wanted to have a minimal patch that fixes all of the compilation errors I've seen.)