Skip to content

Fix #10 's commit to actually build with Godot #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
penggrin12 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #10 's commit to actually build with Godot #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions LibBSP/Source/Structs/MAP/MAPPatch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,16 @@ namespace LibBSP
#if !OLDUNITY
using Vertex = UnityEngine.UIVertex;
#endif
#elif GODOT3
#elif GODOT
using Vector2 = Godot.Vector2;
using Vector3 = Godot.Vector3;
#if GODOT3
using Vector4 = Godot.Quat;
#elif GODOT4
using Vector2 = Godot.Vector2;
using Vector3 = Godot.Vector3;
using Vector4 = Godot.Vector4;
elif NEOAXIS
#endif
Comment on lines +22 to +29
Copy link
Author

@penggrin12 penggrin12 Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a double #if a good idea here? less repeating code is good, right?

using Color = Godot.Color;
#elif NEOAXIS
using Vector2 = NeoAxis.Vector2F;
using Vector3 = NeoAxis.Vector3F;
using Vector4 = NeoAxis.Vector4F;
Expand Down