Skip to content

Conversation

@dmitryan
Copy link
Contributor

The recently used MassiIVE repository's FTP hostname changed from the massive.ucsd.edu to massive-ftp.ucsd.edu. Need to update it to get the MassIVE file downloader worked

@dmitryan
Copy link
Contributor Author

@wfondrie PTAL

@wfondrie
Copy link
Owner

Thank you! This has been on my todo list for awhile.

@wfondrie wfondrie self-requested a review May 30, 2025 14:35
@dmitryan
Copy link
Contributor Author

dmitryan commented Jun 2, 2025

@wfondrie Could you please take a look the changes?

@dmitryan
Copy link
Contributor Author

The gnps-datasetcache.ucsd.edu resource is no longer available. Adopted to work with a new one datasetcache.gnps2.org

@dmitryan dmitryan changed the title Update the MassIVE FTP server hostname Update the MassIVE FTP server hostname; Move to a new datasetcache resource Jun 17, 2025
@dmitryan
Copy link
Contributor Author

@wfondrie PTAL

@wfondrie
Copy link
Owner

Sorry for the delay!

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (fba8b77) to head (cf7eb5f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ppx/massive.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   93.67%   92.58%   -1.10%     
==========================================
  Files           9        9              
  Lines         601      634      +33     
==========================================
+ Hits          563      587      +24     
- Misses         38       47       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wfondrie
Copy link
Owner

I'm not too worried about the missed line. Thanks!

@wfondrie wfondrie merged commit 3a55674 into wfondrie:master Jun 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants