Allow goenv exec to execute abritrary commands.
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just commands that ship with a specific Go version. Some commands (eg gorename) require a GOROOT to be set pointing at a Go source tree. Allowing goenv exec to run any command on the PATH will allow these to work.
alext
added a commit
to alphagov/packager
that referenced
this pull request
Jan 24, 2015
This switches to my fork of goenv because the upstream doesn't seem to be active any more. Version 0.0.6 includes 2 fixes: * fix goenv install to work with the new download URLs for Go 1.3.1+ (wfarr/goenv#13) * update goenv exec to allow running any command on the PATH (wfarr/goenv#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just commands that ship with a specific Go version. Some commands
(eg
gorename) require a GOROOT to be set pointing at a Go source tree.Allowing
goenv execto run any command on the PATH will allow these towork.