Skip to content

Conversation

@wetzja04-dot
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/page-settings/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-14724253
  828  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

Copilot AI review requested due to automatic review settings January 2, 2026 10:28
@continue
Copy link

continue bot commented Jan 2, 2026

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to address a high-severity security vulnerability (SNYK-JS-QS-14724253, score 828) by upgrading @polkadot/apps-config from 0.0.0-use.local to 0.68.1. However, the automated fix appears to be incorrect and introduces a critical version mismatch issue.

Key Changes

  • Updates @polkadot/apps-config dependency version in packages/page-settings/package.json

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"version": "0.166.2-7-x",
"dependencies": {
"@polkadot/apps-config": "^0.166.2-7-x",
"@polkadot/apps-config": "^0.68.1",
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version change from ^0.166.2-7-x to ^0.68.1 appears to be downgrading the package to an older version (0.68.1 is significantly lower than 0.166.2-7-x). This creates a version mismatch with other packages in the monorepo that depend on @polkadot/apps-config at version ^0.166.2-7-x (e.g., packages/apps/package.json line 20).

Additionally, @polkadot/apps-config is a local package in this monorepo (defined in packages/apps-config/package.json at version 0.166.2-7-x), so this change would attempt to pull an external version instead of using the local one. This could lead to dependency resolution issues and runtime errors due to API incompatibilities between the older external version and the rest of the application.

Suggested change
"@polkadot/apps-config": "^0.68.1",
"@polkadot/apps-config": "^0.166.2-7-x",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants