Skip to content

Conversation

@wetzja04-dot
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/page-storage/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improperly Controlled Modification of Dynamically-Determined Object Attributes
SNYK-JS-MDASTUTILTOHAST-14157221
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Improperly Controlled Modification of Dynamically-Determined Object Attributes

Copilot AI review requested due to automatic review settings December 9, 2025 10:03
@continue
Copy link

continue bot commented Dec 9, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This Snyk-generated PR attempts to fix a security vulnerability (SNYK-JS-MDASTUTILTOHAST-14157221) by modifying dependency versions in packages/page-storage/package.json. However, the changes are fundamentally incorrect as they attempt to replace local workspace package references with non-existent external npm versions.

Key Issues:

  • Changes @polkadot/react-components and @polkadot/react-params from workspace versions ^0.166.2-7-x to ^0.34.1
  • Both packages are private local workspace packages that are not published to npm
  • This breaks the monorepo's workspace dependency pattern and will cause build failures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +19 to +20
"@polkadot/react-components": "^0.34.1",
"@polkadot/react-params": "^0.34.1"
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependency version changes are incorrect. Both @polkadot/react-components and @polkadot/react-params are private local workspace packages (not published to npm) with version 0.166.2-7-x. All other packages in this monorepo reference these local workspace packages with version ^0.166.2-7-x, consistent with the workspace pattern.

Changing these to ^0.34.1 will break the build because:

  1. Version 0.34.1 does not exist for these private workspace packages
  2. This breaks the workspace dependency pattern used throughout the monorepo
  3. The packages must reference the local workspace versions, not external npm versions

The correct versions should remain ^0.166.2-7-x for both dependencies. The Snyk fix appears to have incorrectly identified these local workspace packages as external dependencies.

Suggested change
"@polkadot/react-components": "^0.34.1",
"@polkadot/react-params": "^0.34.1"
"@polkadot/react-components": "^0.166.2-7-x",
"@polkadot/react-params": "^0.166.2-7-x"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants