Skip to content

Conversation

@Megapixel99
Copy link
Collaborator

@Megapixel99 Megapixel99 commented Aug 29, 2025

Despite the initial hope of this being a small pull request, there were a lot of required changes to improve the readability of the code and support Express 5. I tried to comment the code as best I could but if something looks off, please add a comment in the PR.

Breaking Changes:

  • Removed support for Express 4
    • We can continue supporting Express 4 on a different branch, if desired

Major Changes:

  • Revamped tests for regex routes to align with Express 5's regex requirements
  • Added a couple more tests to ensure sub routes (routes within routes) worked properly
  • Rewrote lib/generate-doc.js
  • Updated the versions of NodeJS which the tests are running against
  • Removed tests for Express 4
  • Updated express to the latest version
    • Made express a peer dependency
  • Updated router to feat: add getRoutes method to list registered routes pillarjs/router#174 (so we can access getRoutes())

Minor Changes:

@Megapixel99 Megapixel99 requested a review from enov August 29, 2025 18:29
@socket-security
Copy link

socket-security bot commented Aug 29, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@Megapixel99
Copy link
Collaborator Author

This PR is dependent on getRoutes() and should not be merged until getRoutes() is officially released.

@Megapixel99 Megapixel99 force-pushed the express-5 branch 4 times, most recently from 3759e8c to ef0a065 Compare September 2, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants