Open
Conversation
When testing the snippet -- on chrome -- using the `p` letter for the name of the variable will return this error: ```text Uncaught SyntaxError: Identifier 'p' has already been declared at <anonymous>:1:1 ```
On line 114, I do believe `author.Details` is actually supposed to actually be `authorDetails`
Pending issue: when setting the exceptions to the `unused-var` rule, a string that starts with err is described with a tilde `~`. However, later in the text, the same construct is described with a caret `^`. Considering regular expressions I think it's likely a caret, but I am not 100% sure.
Fix initial grammar error.
The last instance of the `convertCurrency` function refers to `tax` and `tip`, but doesn't actually use them. 1.54$ on line 11 is modified to match the value in the following snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found mostly minor issues in the markdown files going from file 28 to file 44.
I stress here one pending issue in file 40 - Airbnb Style Guide:
When setting the exceptions to the
unused-varrule, a string that starts with err is described with a tilde~, as in~err.Later in the text, the same construct is however described with a caret
^, as in^err. Considering regular expressions I think it's likely a caret, but I am not 100% sure.