Open
Conversation
On line 40, tried to also improve the closing sentence.
On line 42, broke the phrases in two simpler sentences, which might help the reader's comprehension.
On line 5, I propose a slight change to improve the flow of the sentence. On line 158, I am unsure as how to best describe the MooTools subordinate.
- remove unnecessary words - add missing words - include backticks around the `arguments` list - change the `querySelector()` method to `querySelectorAll()`, as the method ought to return _all_ paragraph elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the articles 18 to 27, and found a few minor text fixes.
The most noticeable issue was with the
querySelectormethod, which needed to actually bequerySelectorAllas to target all paragraph elements.Hope I'm not proposing too many changes. If I can also improve the way I propose changes let me know.