Rename Array.method to Array.prototype.method#106
Open
anushanadig wants to merge 2 commits intowesbos:masterfrom
Open
Rename Array.method to Array.prototype.method#106anushanadig wants to merge 2 commits intowesbos:masterfrom
anushanadig wants to merge 2 commits intowesbos:masterfrom
Conversation
Rename Array.find and Array.findIndex to Array.prototype.find and Array.prototype.findIndex to make it clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array.findandArray.findIndexconfused me for a while. I thought they were function properties, but in reality, they are prototype methods of Array. I'm a beginner and I thought it'd be confusing for other beginners as well. So I renamed them toArray.prototype.findandArray.prototype.findIndexto make it more clear.