Skip to content

chore: allow Chinese for username #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendyqueen merged 5 commits into from
Jul 12, 2025
Merged

chore: allow Chinese for username #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62c41a1
chore: remove valid for name letters
wendyqueen Jul 12, 2025
e1b122f
fix CI
wendyqueen Jul 12, 2025
3ba1555
fix
wendyqueen Jul 12, 2025
ca64374
fix
wendyqueen Jul 12, 2025
b1378f5
fix
wendyqueen Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tests/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ test('isValidUsername', () => {
expect(validators.isValidUsername('gr1fF_p4tch')).toBe(true);
expect(validators.isValidUsername('griff patch')).toBe(false);
expect(validators.isValidUsername(' griffpatch')).toBe(false);
expect(validators.isValidUsername('abcdé')).toBe(false);
// expect(validators.isValidUsername('abcdé')).toBe(false);
expect(validators.isValidUsername('')).toBe(false);
expect(validators.isValidUsername('e')).toBe(true);
expect(validators.isValidUsername('ee')).toBe(true);
Expand Down
4 changes: 2 additions & 2 deletions src/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ const VALUE_MAX_LENGTH = 100000;
const USERNAME_MAX_LENGTH = 20;
/** Minimum length of usernames, inclusive. */
const USERNAME_MIN_LENGTH = 1;
/** Regex for usernames to match. Letters, numbers, -, and _ */
const USERNAME_REGEX = /^[a-z0-9_-]+$/i;
/** Regex for usernames to match. Any characters except spaces (allows Chinese characters, letters, numbers, -, and _) */
const USERNAME_REGEX = /^[^\s]+$/;

/**
* @param {unknown} username
Expand Down