Exclude build on the i686 architecture #1499
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable the dependency on QEMU to be removed for i686, since QEMU intends to drop i686 support. lorax is NOT currently a leaf package on i686: $ ./leafdrop lorax lorax is Required by: - python-imgcreate-sysdeps lorax is BuildRequired by: - pungi NO: Package lorax is not a leaf package on i686. Considering those two reported deps, python-imgcreate-sysdeps is a sub-RPM from 'livecd-tools' $ rpm -qi python-imgcreate-sysdeps | grep Source Source RPM : livecd-tools-31.0-18.fc43.src.rpm $ ./leafdrop livecd-tools python3-imgcreate is Required by: - appliance-tools NO: Package livecd-tools is not a leaf package on i686. $ ./leafdrop appliance-tools YES: Package appliance-tools is a leaf package on i686. where appliance-tools is 'noarch' so will never be built in an i686 build root, thus 'livecd-tools' has recently have an ExcludeArch added for i686. And 'pungi' is also a 'noarch' so again will never be built in an i686 build root and its only consumer is bodhi-composer, which is a sub-RPM of bodhi-server which is also 'noarch' and thus also won't be built in an i686 build root: $ ./leafdrop pungi pungi is Required by: - bodhi-composer NO: Package pungi is not a leaf package on i686. # rpm -qi bodhi-composer |grep Source Source RPM : bodhi-server-25.5.1-5.fc43.src.rpm $ ./leafdrop bodhi-server YES: Package bodhi-server is a leaf package on i686. Therefore it is viable to exclude i686 for lorax now. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Pull Request Test Coverage Report for Build 19700605367Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable the dependency on QEMU to be removed for i686, since QEMU intends to drop i686 support.
lorax is NOT currently a leaf package on i686:
Considering those two reported deps, python-imgcreate-sysdeps is a sub-RPM from 'livecd-tools'
where appliance-tools is 'noarch' so will never be built in an i686 build root, thus 'livecd-tools' has recently have an ExcludeArch added for i686.
And 'pungi' is also a 'noarch' so again will never be built in an i686 build root and its only consumer is bodhi-composer, which is a sub-RPM of bodhi-server which is also 'noarch' and thus also won't be built in an i686 build root:
Therefore it is viable to exclude i686 for lorax now.