Changes based on NUS BIM-BEM-Continuous Calibration project#1
Open
adChong wants to merge 59 commits intoweilix88:masterfrom
Open
Changes based on NUS BIM-BEM-Continuous Calibration project#1adChong wants to merge 59 commits intoweilix88:masterfrom
adChong wants to merge 59 commits intoweilix88:masterfrom
Conversation
Provide more flexibility for making changes in the idf at a later time by defining OA schedules that are based on spaceName
Provide more flexibility for making changes in the idf at a later time by defining OA schedules that are based on spaceName
Medium Rought changed to Medium Rough
The change ensures that the first element is read as default value from internal loads and space XML file to prevent an error when the gbXML input file has no spaceType attribute
** Severe ** GetSurfaceData: Construction PROJECT PARTITION_REVERSED of interzone surface B-SDE4-01-SPRR154-SDE4-01-SPRR182-I-F-33_REVERSED does not have the same number of layers as the construction PROJECT INTERNAL FLOOR of adjacent surface B-SDE4-01-SPRR154-SDE4-01-SPRR182-I-F-33
** Severe ** Building Surface Detailed, invalid outside boundary condition ....
"!- Name" assigned when it should be "!- Outside Layer"
Reverse surface name error in idf
Construction name error. Reverse of interior floor construction is not the right one.
…ce cases" This reverts commit e4efa56.
**Severe ** ComputeIntSolarAbsorpFactors: Solar distribution model is set to place solar gains on the zone floor
add Curtain Wall judgement
change the order of code.
Add air construction and add more input of the function for air construction
reversedConsName some times got error. with the situation have air construction
logic of the judgement
need to discuss. changes in this function: 1 some hard code value changed that seems made by weili. 2 we delete the heating part in our version
seems weili change this part as well as function translateSpace in GbXMLSpace
addAirConstruction(change) addSubAirConstruction(add) addCurtainConstruction(add)
change to climate zone 1
ASHRAELightData can read the data from the address provided
ASHRAEOAData can read the data from the address provided
DOEReferenceEquipmentData can read the data from the address provided
This reverts commit dcb7ced.
This reverts commit b93d5d8.
ASHRAELightData can read the data from the address provided
ASHRAEOAData can read the data from the address provided
Avoid same construction
let the output file have name
change the floor and room id to name
let our fitted schedule red by the translator
add HVAC system 7 and debug for HVACSystem3.java the loop only have zone except floor
let translator can read light and equipment xml from user
This reverts commit 7a96c7d.
Provide more flexibility for making changes in the idf at a later time by defining OA schedules that are based on spaceName
change config to relative path
upload xml input doc
wrongly changed the readed file, change it back
make equipment can read equipment schedule from the provided xml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the large pull request