Conversation
gersmann
reviewed
Aug 4, 2025
| if isinstance(ov, re.Pattern) and isinstance(doc, str): | ||
| if ov.search(doc): | ||
| return True | ||
| return bool(ov.search(doc)) |
Collaborator
There was a problem hiding this comment.
regarding this, if one is a pattern and the other side is not a string, but for instance an UUID - we could coerce to string, yes, could technically be helpful in the good old ObjectId as a/b bucket flag scenario, or some more advanced filter logic. But on the other hand I haven't thought through possible failure modes, so maybe best to just keep it as is for now.
gersmann
reviewed
Aug 4, 2025
| original values so the caller can attempt a normal comparison. | ||
| """ | ||
|
|
||
| match (a, b): |
Collaborator
There was a problem hiding this comment.
nice, that's a good use case for that
gersmann
approved these changes
Aug 4, 2025
Collaborator
gersmann
left a comment
gersmann
left a comment
There was a problem hiding this comment.
Works for us, the tests we have (not exhaustive in all fairness) are green.
Owner
Author
I will merge and release. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @gersmann stefan@gersmann.de