-
Notifications
You must be signed in to change notification settings - Fork 10
Replace deprecated request deps and use fetch #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
799510f to
b6be38d
Compare
eliasMC89
reviewed
Apr 10, 2025
eliasMC89
reviewed
Apr 10, 2025
eliasMC89
reviewed
Apr 10, 2025
eliasMC89
reviewed
Apr 10, 2025
eliasMC89
reviewed
Apr 10, 2025
eliasMC89
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/weekendesk/tech-management/issues/1480
Scope
We have a number of critical, high and moderate vulnerabilities in weekendesk-gateway-frontoffice that are due to lack of updates in our dependencies.
Solution
All vulnerabilities are coming from
requestandrequest-promise-nativewhich are deprecated and unmaintained since 2020.fetchmethod (since Node 18, it's supported) instead ofrequestandrequest-promise-nativenockon all unit tests. It's a way to intercept requests but it's not working withfetchAlso this PR introduces some breaking changes:
I'm also updating:
Express.jswhere there are some breaking changesbody-parserthe only breaking change is Node.js 18 is the minimum supported versionI've updated this repository protection branch rule to use only node 20:
