Allow INA3221 overrides and fix INA219 conflict#37
Open
andyshinn wants to merge 2 commits intoweebl2000:dev_plusfrom
Open
Allow INA3221 overrides and fix INA219 conflict#37andyshinn wants to merge 2 commits intoweebl2000:dev_plusfrom
andyshinn wants to merge 2 commits intoweebl2000:dev_plusfrom
Conversation
This adds a support for defining alternate INA3221 addresses. It also adds some special handling in the case you change the address to 0x40 and it conflicts with INA219. In that case, the INA3221 responds to INA219 commands, but with garbage data
There was a problem hiding this comment.
Pull request overview
This PR makes the INA3221 configuration more flexible and prevents probing an INA219 when it would conflict with an already-initialized INA3221 on the same I2C address.
Changes:
- Add
#ifndefguards soTELEM_INA3221_ADDRESSandTELEM_INA3221_SHUNT_VALUEcan be overridden externally. - Skip INA219 initialization when INA3221 is initialized and both are configured for the same I2C address.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the INA3221 address and shunt values to be overridden since not all are the same.