Open
Conversation
Collaborator
Author
|
@netweng PTAL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZZZJX0912
force-pushed
the
DatePickerAbility
branch
from
ad6745c to
96880ed
Compare
Contributor
|
Deploy preview for cloudtower-ui-kit-eagle ready! ✅ Preview Built with commit 96880ed. |
netweng
reviewed
Feb 25, 2025
| @@ -1,5 +1,5 @@ | |||
| import { | |||
| DatePicker, | |||
| DatePicker as AntdDatePicker, | |||
Member
There was a problem hiding this comment.
如果是直接透穿的，那就叫 antdatepicker 就好了，原来的可以保持不变，不然这样其他使用 eagle 的地方一升级就 breaking change 了。
| } from "antd"; | ||
|
|
||
| export const DatePickerRangePicker = DatePicker.RangePicker; | ||
| export const DatePickerRangePicker = AntdDatePicker.RangePicker; |
| @@ -0,0 +1,28 @@ | |||
| import { InputStyle } from "@src/core/Styled"; | |||
| import { Typo } from "@src/core/Typo"; | |||
| import { DatePicker as AntdDatePicker } from "antd"; | |||
Collaborator
Author
There was a problem hiding this comment.
thread里有说，两种方案，要不就最小花销，只提供error的渲染能力，要不就直接引入antd5的组件，目前就最小花销的方式处理，我看thread里没有异议呀
| }) => ( | ||
| <div className="datatime-range"> | ||
| <DatePicker.RangePicker | ||
| <AntdDatePicker.RangePicker |
Collaborator
Author
There was a problem hiding this comment.
嗯，我全部处理一下，磨平AntdDatePicker 和 DatePicker的差异
| toWeeklyString, | ||
| } from "@src/utils"; | ||
| import { DatePicker } from "antd"; | ||
| import { DatePicker as AntdDatePicker } from "antd"; |
| @@ -5,7 +5,7 @@ import { | |||
| Checkbox as AntdCheckbox, | |||
Member
There was a problem hiding this comment.
这个文件不预期改动，只有还在用 useUIKit 这个废弃 hook 的地方才会用到
| /** | ||
| * * antd4 组件 | ||
| * * 更多 props 请参考：https://4x.ant.design/components/date-picker-cn/#API | ||
| * * 自定义 props 已在表格进行说明 |
| Button as AntdButton, | ||
| Checkbox as AntdCheckbox, | ||
| Collapse as AntdCollapse, | ||
| DatePicker as AntdDatePicker, |
Member
There was a problem hiding this comment.
这里我就没太理解了，我们到底是对外提供项目内的 datapicker 还是 antd 的？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自测截图