Fix critical bugs and improve code quality from code review #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix toggleConnection() logic bug that always treated connections as disconnected - Add identifier validation for SQL metadata queries to prevent injection - Fix async forEach pattern in loadTableMetadataInBackground using Promise.allSettled - Extract SSH tunnel setup to private helper method to eliminate duplication - Add formatError() helper for better error message handling - Add cleanup() method for persistence timer to prevent memory leaks - Add aria-labels to icon-only buttons for accessibility (with i18n support) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
toggleConnection()logic bug that always treated connections as disconnectedloadTableMetadataInBackgroundusingPromise.allSettledformatError()helper for better error message handlingcleanup()method for persistence timer to prevent memory leaksTest plan
🤖 Generated with Claude Code