Add meta tag support for custom skybox #115
Conversation
This update introduces a new meta tag for specifying a custom skybox URL. The meta tag allows users to set a cube map URL, which is then incorporated into the render loop using native three.js functionality. The existing skybox behavior is disabled when a custom skybox is specified. This enhancement addresses issue #60.
|
A good start - please review dom-utils.js for how to properly manage the meta tag state, particularly note how the terrain meta tags are dealt with since this would largely fall under the same umbrella. |
gfodor
left a comment
gfodor
left a comment
There was a problem hiding this comment.
A good start - please review dom-utils.js for how to properly manage the meta tag state, particularly note how the terrain meta tags are dealt with since this would largely fall under the same umbrella.
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
There was a problem hiding this comment.
I'll update the PR to manage the meta tag state properly by reviewing and aligning with the approach used in dom-utils.js, especially how terrain meta tags are handled.
Thanks for using MentatBot. Reply with feedback or to ask MentatBot to review other parts of the PR. Please give feedback with emoji reacts.
This update introduces a new meta tag for specifying a custom skybox URL. The meta tag allows users to set a cube map URL, which is then incorporated into the render loop using native three.js functionality. The existing skybox behavior is disabled when a custom skybox is specified. Additionally, the code has been updated to properly manage the meta tag state by utilizing functions from `dom-utils.js`, aligning with how terrain meta tags are handled. This enhancement addresses issue #60. Closes #60
1 participant
This update introduces a new meta tag for specifying a custom skybox URL. The meta tag allows users to set a cube map URL, which is then incorporated into the render loop using native three.js functionality. The existing skybox behavior is disabled when a custom skybox is specified. This enhancement addresses issue #60.
Closes #60