Skip to content

Exclude rhumb from the build #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstade merged 7 commits into from
Nov 5, 2015
Merged

Exclude rhumb from the build #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a73fa02
Quick and dirty change to exclude rhumb from the build
mstade Nov 4, 2015
6a964c9
Append `node_modules/.bin`, instead of prepending, to `$PATH`
mstade Nov 4, 2015
ed03c48
Remove node modules from PATH, see if this fixes Travis build
mstade Nov 5, 2015
5386d17
Print PATH so we can tell WTH travis is doing
mstade Nov 5, 2015
d9ed8fe
Clean PATH env var of ./node_modules/.bin
mstade Nov 5, 2015
950d848
Remove PATH echoing in travis config
mstade Nov 5, 2015
a055322
0.10.0
mstade Nov 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PATH := node_modules/.bin:$(PATH)
SHELL := /bin/bash
PATH := $(shell echo $${PATH//\.\/node_modules\/\.bin:/}):node_modules/.bin

SRC = $(wildcard src/*.js)
LIB = $(SRC:src/%.js=lib/%.js)
Expand All @@ -11,7 +11,7 @@ v ?= patch
build: node_modules $(LIB)
lib/%.js: src/%.js
@mkdir -p $(@D)
@browserify $< --standalone $(@F:%.js=%) | uglifyjs -o $@
@browserify --exclude @websdk/rhumb $< --standalone $(@F:%.js=%) > $@

node_modules: package.json
$(NPM)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@websdk/nap",
"version": "0.9.8",
"version": "0.10.0",
Copy link

@grancalavera grancalavera Nov 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you bumping the version by hand?

Copy link
Member Author

@mstade mstade Nov 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, using npm version. I'm going with the no-one-really-cares-about-semver-before-1.0 approach, so bumping minor for the breaking changes and patch for non-breaking. Once we hit 1.0.0 though we should take better care.

Copy link

@grancalavera grancalavera Nov 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

"description": "Organizing applications into resources",
"main": "lib/nap.js",
"devDependencies": {
Expand Down