feat(config): add serde Serialize/Deserialize to RTCConfiguration#81
Open
nightness wants to merge 1 commit intowebrtc-rs:masterfrom
Open
feat(config): add serde Serialize/Deserialize to RTCConfiguration#81nightness wants to merge 1 commit intowebrtc-rs:masterfrom
nightness wants to merge 1 commit intowebrtc-rs:masterfrom
Conversation
Adds serde round-trip support to RTCConfiguration using W3C camelCase field names (iceServers, iceTransportPolicy, bundlePolicy, rtcpMuxPolicy, peerIdentity, iceCandidatePoolSize). All dependent types already had serde derives (RTCIceServer, RTCBundlePolicy, RTCIceTransportPolicy, RTCRtcpMuxPolicy, RTCSdpSemantics). Certificates are excluded via #[serde(skip)] because they contain private-key material. Use RTCCertificate::serialize_pem() / from_pem() to persist certificates separately. Adds test_configuration_json_round_trip to replace the previously commented-out Go test with a Rust equivalent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[derive(Serialize, Deserialize)]with#[serde(rename_all = "camelCase")]toRTCConfigurationand nested types (RTCIceServer, etc.)serdefeature gate so it's opt-inTest plan
cargo test -p rtc test_configuration_json_round_tripiceServers,iceTransportPolicy, etc.) in serialized output🤖 Generated with Claude Code