Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rtc-ice/src/candidate/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ mod candidate_pair_test;
#[cfg(test)]
mod candidate_test;

//TODO: #[cfg(test)]
//TODO: mod candidate_relay_test;
/*TODO: #[cfg(test)]
TODO: mod candidate_server_reflexive_test;
*/
// candidate_relay_test and candidate_server_reflexive_test use turn::auth / turn::server /
// turn::relay APIs from a different TURN library than rtc-turn. Enabling them requires porting
// to the rtc-turn API — deferred to a dedicated porting effort.
// #[cfg(test)] mod candidate_relay_test;
// #[cfg(test)] mod candidate_server_reflexive_test;

pub mod candidate_host;
pub mod candidate_pair;
Expand Down
4 changes: 2 additions & 2 deletions rtc/src/peer_connection/configuration/media_engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
//! # }
//! ```

//TODO:#[cfg(test)]
//mod media_engine_test;
// media_engine_test.rs does not exist — it was never created for this sans-IO crate.
// #[cfg(test)] mod media_engine_test;

use crate::peer_connection::sdp::{
codecs_from_media_description, rtp_extensions_from_media_description,
Expand Down
40 changes: 3 additions & 37 deletions rtc/src/peer_connection/configuration/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -749,41 +749,7 @@ mod test {
}
}

/*TODO:#[test] fn test_configuration_json() {

let j = r#"
{
"iceServers": [{"URLs": ["turn:turn.example.org"],
"username": "jch",
"credential": "topsecret"
}],
"iceTransportPolicy": "relay",
"bundlePolicy": "balanced",
"rtcpMuxPolicy": "require"
}"#;

conf := Configuration{
ICEServers: []ICEServer{
{
URLs: []string{"turn:turn.example.org"},
Username: "jch",
Credential: "topsecret",
},
},
ICETransportPolicy: ICETransportPolicyRelay,
BundlePolicy: BundlePolicyBalanced,
RTCPMuxPolicy: RTCPMuxPolicyRequire,
}

var conf2 Configuration
assert.NoError(t, json.Unmarshal([]byte(j), &conf2))
assert.Equal(t, conf, conf2)

j2, err := json.Marshal(conf2)
assert.NoError(t, err)

var conf3 Configuration
assert.NoError(t, json.Unmarshal(j2, &conf3))
assert.Equal(t, conf2, conf3)
}*/
// test_configuration_json was Go code that was never ported to Rust.
// A Rust equivalent would deserialize RTCConfiguration from JSON and round-trip it.
// This can be added as a proper #[test] if JSON serialization is a desired feature.
}
5 changes: 3 additions & 2 deletions rtc/src/peer_connection/sdp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,9 @@
//! [RFC 8829]: https://datatracker.ietf.org/doc/html/rfc8829
//! [W3C WebRTC Specification]: https://w3c.github.io/webrtc-pc/#session-description-model

//TODO: #[cfg(test)]
//TODO: mod sdp_test;
// sdp_test.rs imports crate::api::APIBuilder which belongs to the old async API and does not
// exist in this sans-IO crate. Enabling it requires porting the test file to the new API.
// #[cfg(test)] mod sdp_test;

pub(crate) mod sdp_type;
pub(crate) mod session_description;
Expand Down