Skip to content

fix(sctp): correct PR-SCTP max_retransmits abandonment condition #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightness wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sctp): correct PR-SCTP max_retransmits abandonment condition #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rtc-sctp/src/association/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2522,7 +2522,12 @@ impl Association {
let reliability_value = s.reliability_value;

if reliability_type == ReliabilityType::Rexmit {
if c.nsent >= reliability_value {
// RFC 3758 §5.3.1: abandon when transmitted MORE THAN max_retransmits times.
// Use `>` not `>=`: with max_retransmits=N the chunk may be sent N+1 times total
// (1 initial + N retransmissions), so abandon when nsent > N (reliability_value).
// Using `>=` would incorrectly abandon after only N total sends (one too few).
// Fixes: webrtc-rs/webrtc#776
if c.nsent > reliability_value {
c.set_abandoned(true);
trace!(
"[{}] marked as abandoned: tsn={} ppi={} (remix: {})",
Expand Down