Skip to content

fix(interceptor): clamp total_lost to signed 24-bit max per RFC 3550 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightness wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix(interceptor): clamp total_lost to signed 24-bit max per RFC 3550 #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rtc-interceptor/src/report/receiver_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,12 @@ impl ReceiverStream {

self.total_lost += total_lost_since_report;

// allow up to 24 bits
if total_lost_since_report > 0xFFFFFF {
total_lost_since_report = 0xFFFFFF;
// allow up to signed 24 bits (RFC 3550 §6.4.1: total_lost is i32)
if total_lost_since_report > 0x7FFFFF {
total_lost_since_report = 0x7FFFFF;
}
if self.total_lost > 0xFFFFFF {
self.total_lost = 0xFFFFFF
if self.total_lost > 0x7FFFFF {
self.total_lost = 0x7FFFFF
}

// Calculate DLSR (Delay Since Last SR) - RFC 3550
Expand Down