fix(rtp): associate repair SSRC with base stream RTX parameters (closes #12)#72
Open
nightness wants to merge 1 commit intowebrtc-rs:masterfrom
Open
fix(rtp): associate repair SSRC with base stream RTX parameters (closes #12)#72nightness wants to merge 1 commit intowebrtc-rs:masterfrom
nightness wants to merge 1 commit intowebrtc-rs:masterfrom
Conversation
webrtc-rs#12) Implements rrid (urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id) handling, resolving webrtc-rs#12. rrid is already parsed from RTP header extensions and the URI is registered — the handler body was a TODO stub. When an RTP packet carries rrid, it is a repair/RTX stream for the base stream identified by that rrid value (= the base stream's rid). Map the repair SSRC into the base stream's coding parameters' RTX field so downstream routing and stats can correlate the repair stream with its source stream. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nightness
force-pushed
the
fix/rrid-support
branch
from
326526f to
2b4b96b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
rrid(urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id) handling, closing #12.What was missing: The
rridextension was already parsed from RTP header extensions and the URI already registered inconfigure_simulcast_extension_headers(). The handler body atendpoint.rs:450was a TODO stub.What
rridmeans: when an RTP packet carriesrrid = "X", it is a repair/RTX stream for the base stream whoserid = "X". The repair packet's SSRC should be stored in the base stream'sRTCRtpCodingParameters.rtx.ssrcfield.Fix: when
rridis non-empty, look up the base stream's coding parameters usingget_coding_parameter_mut_by_rid(rrid)and set the RTX SSRC — creating or updating theRTCRtpRtxParametersas needed.Test plan
cargo buildpassescargo test -p rtcpasses (246 tests)🤖 Generated with Claude Code