Skip to content

Fix Webrpc client header, should be enabled by default #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkieltyka merged 2 commits into from
Nov 7, 2025
Merged

Fix Webrpc client header, should be enabled by default #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
280ca42
Fix Webrpc client header, should be enabled by default
VojtechVitek Nov 7, 2025
0a0b7e6
Fix version
VojtechVitek Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ As you can see, the `-target` supports default `typescript`, any git URI, or a l

Change any of the following values by passing `-option="Value"` CLI flag to `webrpc-gen`.

| webrpc-gen -option | Description | Default value | Version |
| ------------------ | -------------------- | ------------------------------------------------- | ------- |
| `-client` | generate client code | unset (`false`) | v0.0.1 |
| `-server` | generate server code | unset (`false`) | v0.0.1 |
| `-webrpcHeader` | `true` | enable client send webrpc version in http headers | v0.15.0 |
| webrpc-gen -option | Description | Default value | Version |
| ------------------ | --------------------------------------- | ------------- | ------- |
| `-client` | generate client code | `false` | v0.0.1 |
| `-server` | generate server code | `false` | v0.0.1 |
| `-webrpcHeader` | send Webrpc header in all HTTP requests | `true` | v0.15.0 |

**Note:** Generated code requires ES2022+ runtime environment.

Expand Down
2 changes: 1 addition & 1 deletion _examples/node-ts/server-fastify/server.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable */
// node-ts v1.0.0 21701cae51b73d035bf2180831cdb38220bbbccc
// --
// Code generated by Webrpc-gen@v0.30.1-1-gda1b8b7 with ../../../gen-typescript generator. DO NOT EDIT.
// Code generated by Webrpc-gen@v0.30.2 with ../../../gen-typescript generator. DO NOT EDIT.
//
// webrpc-gen -schema=service.ridl -target=../../../gen-typescript -server -out=./server-fastify/server.gen.ts

Expand Down
2 changes: 1 addition & 1 deletion _examples/node-ts/server-hono/server.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable */
// node-ts v1.0.0 21701cae51b73d035bf2180831cdb38220bbbccc
// --
// Code generated by Webrpc-gen@v0.30.1-1-gda1b8b7 with ../../../gen-typescript generator. DO NOT EDIT.
// Code generated by Webrpc-gen@v0.30.2 with ../../../gen-typescript generator. DO NOT EDIT.
//
// webrpc-gen -schema=service.ridl -target=../../../gen-typescript -server -out=./server-hono/server.gen.ts

Expand Down
2 changes: 1 addition & 1 deletion _examples/node-ts/server/server.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable */
// node-ts v1.0.0 21701cae51b73d035bf2180831cdb38220bbbccc
// --
// Code generated by Webrpc-gen@v0.30.1-1-gda1b8b7 with ../../../gen-typescript generator. DO NOT EDIT.
// Code generated by Webrpc-gen@v0.30.2 with ../../../gen-typescript generator. DO NOT EDIT.
//
// webrpc-gen -schema=service.ridl -target=../../../gen-typescript -server -out=./server/server.gen.ts

Expand Down
4 changes: 2 additions & 2 deletions _examples/node-ts/webapp/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable */
// node-ts v1.0.0 21701cae51b73d035bf2180831cdb38220bbbccc
// --
// Code generated by Webrpc-gen@v0.30.1-1-gda1b8b7 with ../../../gen-typescript generator. DO NOT EDIT.
// Code generated by Webrpc-gen@v0.30.2 with ../../../gen-typescript generator. DO NOT EDIT.
//
// webrpc-gen -schema=service.ridl -target=../../../gen-typescript -client -out=./webapp/client.gen.ts

Expand Down Expand Up @@ -147,7 +147,7 @@ export class Example implements ExampleClient {
}

const createHttpRequest = (body: string = '{}', headers: object = {}, signal: AbortSignal | null = null): object => {
const reqHeaders: { [key: string]: string } = { ...headers, 'Content-Type': 'application/json' }
const reqHeaders: { [key: string]: string } = { ...headers, 'Content-Type': 'application/json', WebrpcHeader: WebrpcHeaderValue }
Copy link
Member

@pkieltyka pkieltyka Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is incorrect here ... we're using the key "WebrpcHeader"

return { method: 'POST', headers: reqHeaders, body, signal }
}

Expand Down
4 changes: 2 additions & 2 deletions _examples/sse/webapp/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable */
// webrpc-sse-chat v1.0.0 a799dc63b082644f5d003c8881424546aee23a2c
// --
// Code generated by Webrpc-gen@v0.30.1-1-gda1b8b7 with ../../ generator. DO NOT EDIT.
// Code generated by Webrpc-gen@v0.30.2 with ../../ generator. DO NOT EDIT.
//
// webrpc-gen -schema=service.ridl -target=../../ -client -out=./webapp/client.gen.ts

Expand Down Expand Up @@ -274,7 +274,7 @@ const sseResponse = async (


const createHttpRequest = (body: string = '{}', headers: object = {}, signal: AbortSignal | null = null): object => {
const reqHeaders: { [key: string]: string } = { ...headers, 'Content-Type': 'application/json' }
const reqHeaders: { [key: string]: string } = { ...headers, 'Content-Type': 'application/json', WebrpcHeader: WebrpcHeaderValue }
return { method: 'POST', headers: reqHeaders, body, signal }
}

Expand Down
5 changes: 1 addition & 4 deletions clientHelpers.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@

{{- "\n" -}}
const createHttpRequest = (body: string = '{}', headers: object = {}, signal: AbortSignal | null = null): object => {
const reqHeaders: { [key: string]: string } = { ...headers, 'Content-Type': 'application/json' }
{{- if eq $opts.webrpcHeader true }}
reqHeaders[WebrpcHeader] = WebrpcHeaderValue
{{- end }}
const reqHeaders: { [key: string]: string } = { ...headers, 'Content-Type': 'application/json' {{- if eq $opts.webrpcHeader true }}, WebrpcHeader: WebrpcHeaderValue{{ end }} }
return { method: 'POST', headers: reqHeaders, body, signal }
}

Expand Down
2 changes: 1 addition & 1 deletion main.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{{- set $opts "client" (ternary (in .Opts.client "" "true") true false) -}}
{{- set $opts "server" (ternary (in .Opts.server "" "true") true false) -}}
{{- set $opts "compat" (ternary (in .Opts.compat "" "true") true false) -}}
{{- set $opts "WebrpcHeader" (ternary (eq (default .Opts.WebrpcHeader "true") "false") false true) -}}
{{- set $opts "webrpcHeader" (ternary (eq (default .Opts.webrpcHeader "true") "false") false true) -}}

{{- /* Print help on -help. */ -}}
{{- if exists .Opts "help" -}}
Expand Down
Loading