Skip to content

make regex case insensitive#2

Open
sarchila wants to merge 1 commit intowebmodules:masterfrom
sarchila:SA-case-insensitive
Open

make regex case insensitive#2
sarchila wants to merge 1 commit intowebmodules:masterfrom
sarchila:SA-case-insensitive

Conversation

@sarchila
Copy link
Copy Markdown

Not sure if this below is the intended behavior, but I've been running into issues with the case-sensitivity of the regex.

> var urlregexp = require('urlregexp')

> !!('google.com'.match(urlregexp)) // true
> !!('www.google.com'.match(urlregexp)) // true

> !!('Google.Com'.match(urlregexp)) // false
> !!('WWW.GOOGLE.COM'.match(urlregexp)) // false

This is a quick change that makes these all return true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant