Implement element-wise unary operation -- copy op #52
Conversation
huningxin
left a comment
huningxin
left a comment
There was a problem hiding this comment.
LGTM with a comment, thanks!
test/unary_test.js
Outdated
| [3, 2, 2, 1]); | ||
| }); | ||
|
|
||
| it('identity', function() { |
There was a problem hiding this comment.
You may want to cover 0-D scalar input. @fdwr is working on the spec change and I am working a CL to Chromium. It would be good to have WPT test coverage as well. Thanks.
There was a problem hiding this comment.
@fdwr is working on the spec change
I'm a little behind (got COVID Wednesday), but feeling better - I should continue Monday. 🤞
There was a problem hiding this comment.
No worries, glad to hear you are feeling better, have a good recovery first.
BruceDai
changed the title
|
To align with webmachinelearning/webnn#478, I renamed identity to copy. @huningxin @fdwr Please take another look, thanks. |
|
Note the spec is in active review, and there probably will be feedback from reviewers, and quite possibly additional renames. So it probably doesn't make sense to make too many of these renaming changes while the spec change is still in active review. |
3 participants
@huningxin @fdwr PTAL, thanks.