Skip to content

Conversation

@BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Dec 20, 2024

This PR is to fix #86.

@fdwr @huningxin PTAL, thanks!

Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, just minor thoughts.

@BruceDai
Copy link
Contributor Author

BruceDai commented Jan 2, 2025

I've addressed your comments in new commit. Please take another look, thanks! ☕

Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huningxin huningxin merged commit 321e9db into webmachinelearning:main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement scatterNd

3 participants