Skip to content

Conversation

@MikeNeilson
Copy link

Changes javax to jakarta namespace.
Changes minimum Java to 11
Also updates Mockito

This should likely just be another branch to run in parallel, however I can't do that with a simple PR.

Fixes #15

@jamesward
Copy link
Member

Thanks for this! Can you get CI passing?

@MikeNeilson
Copy link
Author

that should work now, did run mvn verify locally but managed to forget about any action... whelp.

@jamesward
Copy link
Member

Thanks. I think the action is using some other outdated stuff. Let me know if you want me to get it updated :)

@MikeNeilson
Copy link
Author

MikeNeilson commented Dec 6, 2025

Thanks. I think the action is using some other outdated stuff. Let me know if you want me to get it updated :)

i just did so in the branch.

@MikeNeilson
Copy link
Author

well now i'm just confused but i don't use maven often so perhaps mvn verify and mvn test don't quite line up. I'll dig more.

@MikeNeilson
Copy link
Author

Okay now it should work.

@jamesward jamesward merged commit 2a7d653 into webjars:master Dec 6, 2025
1 check passed
@jamesward
Copy link
Member

Thanks for doing all this! I'll get a release out shortly.

@jamesward
Copy link
Member

The release is now on Maven Central: org/webjars:webjars-servlet-6.x:1.7
Let me know if you have any problems. Thanks again!

@MikeNeilson
Copy link
Author

No problem, thanks for jumping on the PR so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can we get a jakarta based version?

2 participants