filter: use document text for encoding-safe filtering#215
Merged
Conversation
On Windows, log files may use non-UTF-8 encoding (e.g. CP949, UTF-16). VS Code auto-detects and decodes these correctly, but LogProcessor always read from disk as UTF-8, causing filter matches to fail while highlights worked fine. Pass document.getText() directly to LogProcessor when available so filtering uses the same decoded text that VS Code displays. For large files (>50MB) without a document, the existing disk read path is preserved. This also removes the now-unnecessary temp file workaround for untitled documents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📦 Artifact ReadyDownload the extension package here: |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 59.38% 59.31% -0.07%
==========================================
Files 59 59
Lines 14747 14707 -40
Branches 1014 1011 -3
==========================================
- Hits 8758 8724 -34
+ Misses 5969 5963 -6
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document.getText()toLogProcessor.processFilevia a newcontentoption instead of reading files from disk withfs.createReadStreamTest plan
🤖 Generated with Claude Code