runbook: fix init race and Windows encoding#213
Merged
Conversation
The default System Check group does not appear in the sidebar until the user manually adds a new group. This happens because the async initialization populates items but never notifies the tree view. Fire the change event after loadConfig() so the view updates immediately. On Windows, non-ASCII error messages (e.g. Korean) from runbook script execution are garbled because cmd.exe outputs in the system OEM code page (cp949) while Node.js decodes as UTF-8. Prepend chcp 65001 to switch the console to UTF-8 before running the user script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📦 Artifact ReadyDownload the extension package here: |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 59.33% 59.21% -0.13%
==========================================
Files 59 59
Lines 14744 14747 +3
Branches 1012 1009 -3
==========================================
- Hits 8749 8732 -17
- Misses 5975 5995 +20
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chcp 65001) before executing runbook scriptsTest plan
🤖 Generated with Claude Code