fix: fix clearing time #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package version and refines the scheduler behavior by removing the fallback to initial date values when determining publish and archive times.
- Version bump in package.json from 1.0.8 to 1.1.0
- Removed fallback to initialData for both publishAt and archiveAt in the Scheduler component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Bumped the version to reflect new changes |
| admin/src/components/Scheduler/index.tsx | Updated publishAt and archiveAt logic to use only modifiedData |
Comments suppressed due to low confidence (1)
admin/src/components/Scheduler/index.tsx:27
- Similar to the publishAt block, the dependency array still includes 'initialData.archiveAt'. Consider updating the dependencies to include only relevant values to maintain clarity and consistency.
const newDate = modifiedData?.archiveAt;
| const newDate = modifiedData?.publishAt ?? initialData.publishAt; | ||
| const newDate = modifiedData?.publishAt; | ||
| return newDate ? new Date(newDate) : null; | ||
| }, [initialData.publishAt, modifiedData.publishAt]); |
There was a problem hiding this comment.
The dependency array for this useMemo still includes 'initialData.publishAt', but since the fallback has been removed, it may be clearer to remove 'initialData.publishAt' from the dependencies to avoid any confusion.
Suggested change
| }, [initialData.publishAt, modifiedData.publishAt]); | |
| }, [modifiedData.publishAt]); |
MaikaiMa
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.