Open
Conversation
This reverts commit 0fd4da1.
Contributor
|
Didn't this cause breakage in physics on testing? Additionally,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I investigated the "physics" parameter issue in the .scn files
and I noticed that parameter is not being used anywhere
and the only reason we have had physics in objects is because we set it to true manually ( in app-manager.js )
so here's what I suggest we do :
and finally here's what the user experiences :
physicscomponent is not specified in the .scn file, we're going to enable physics for the object by defaultphysicscomponent is set totruewe enable and if it's set tofalsewe disable physics for that object