Set bone to name in action instead of entire bone to prevent buffer overflow#106
Open
lalalune wants to merge 2 commits intowebaverse:mainfrom
Open
Set bone to name in action instead of entire bone to prevent buffer overflow#106lalalune wants to merge 2 commits intowebaverse:mainfrom
lalalune wants to merge 2 commits intowebaverse:mainfrom
Conversation
Right now when trying to mount the dragon, there is a buffer overflow error because wsrtc is trying to serialize the entire bone. We really just want the bone name, I think, and indeed these seems to work alright for us in the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when trying to mount the dragon, there is a buffer overflow error because wsrtc is trying to serialize the entire bone. We really just want the bone name, I think, and indeed these seems to work alright for us in the app.