Closed
Conversation
avaer
reviewed
Nov 3, 2021
|
|
||
|
|
||
| function initWindParameters(rig) { | ||
| var hairPhysics = rig.app.getComponent('hairPhysics'); |
Contributor
There was a problem hiding this comment.
"Hair physics" is not the best name, since all avatars should have hair physics and not having this component won't change that. This is about wind.
avaer
reviewed
Nov 3, 2021
| return; | ||
| } | ||
|
|
||
| if (!hairPhysics.hasOwnProperty('windDirectionX')) hairPhysics.windDirectionX = 0.0; |
Contributor
There was a problem hiding this comment.
Shouldn't the wind direction be gotten from the component?
Contributor
There was a problem hiding this comment.
Components have a value which you can get look at.
Contributor
Author
|
I have created new PR with fresh copy of webaverse: That is the reason for closing this PR All requests are addressed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have change everything commented in previous PR.