Skip to content

use insertAdjacentText instead of insecure deprecated document.write #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdipierro merged 2 commits into from
Sep 18, 2025
Merged

use insertAdjacentText instead of insecure deprecated document.write #1000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1e16e
use insertAdjacentText instead of insecure deprecated document.write
laundmo Sep 16, 2025
e36ea11
use JS isoformat parsing
laundmo Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions py4web/utils/grid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,15 +397,8 @@ def datetime_represent(value):
if not value or not isinstance(value, datetime.datetime):
return value or ""
return XML(
"<script>document.write((new Date(%s,%s,%s,%s,%s,%s)).toLocaleString())</script>"
% (
value.year,
value.month - 1,
value.day,
value.hour,
value.minute,
value.second,
)
"<script>document.currentScript.insertAdjacentText('afterend',"
f"(new Date('{value.isoformat(timespec='seconds')}')).toLocaleString())</script>"
)


Expand All @@ -414,12 +407,8 @@ def date_represent(value):
if not value or not isinstance(value, datetime.date):
return value or ""
return XML(
'<script>document.write((new Date(%s,%s,%s)).toLocaleString().split(",")[0])</script>'
% (
value.year,
value.month - 1,
value.day,
)
"<script>document.currentScript.insertAdjacentText('afterend',"
f"(new Date('{value.isoformat()}')).toLocaleDateString())</script>"
)


Expand All @@ -428,8 +417,8 @@ def time_represent(value):
if not value or not isinstance(value, datetime.time):
return value or ""
return XML(
"<script>document.write((new Date(0, 0, 0,%s,%s,%s)).toLocaleString().split(', ')[1])</script>"
% (value.hour, value.minute, value.second)
"<script>document.currentScript.insertAdjacentText('afterend',"
f"(new Date('0000T{value.isoformat('seconds')}')).toLocaleTimeString())</script>"
)


Expand Down