fix: use dev extras in CI; remove test-requirements.txt#198
Open
Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Open
fix: use dev extras in CI; remove test-requirements.txt#198Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR resolves duplicate test dependency definitions by removing test-requirements.txt and switching CI to install the dev optional dependencies from pyproject.toml (Fixes #197).
Changes:
- Deleted
test-requirements.txtto eliminate the second source of test dependencies. - Updated CircleCI to install
.[dev]instead of-r test-requirements.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test-requirements.txt |
Removed legacy test dependency list in favor of pyproject.toml extras. |
.circleci/config.yml |
CI now installs the project with dev extras before running pytest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rotzbua
force-pushed
the
fix_test_requirements
branch
from
ae60e54 to
022b748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use dev extras in CI; remove test-requirements.txt
Testing
Run tests.
Issue(s)
Fixes #197